fixed a resource leak that prevented status iterators from cleaning properly #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing for status was in an async function - the loop would terminate, but the actual closing didn't finish so any code following the async loop didn't execute. also simplified handling of connection status listeners (listeners were tracked by the connection and the protocol - now only by the protocol), fixed a leak on dial where a promise was not cancelled for the wait between dial interval. fix(test): jetstream test was not really testing the status listener leaks Fix #134 Signed-off-by: Alberto Ricart <[email protected]>
aricart
changed the title
mtmk
reviewed
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #134